feat: add JDK 25 image variants - #42
Merged
Merged
Conversation
Add node20/22/24-jdk25 entries pointing at the existing ghcr.io/ringcentral-docker/node:*-jdk25 base image tags. Gradle is bumped to 9.7.1 for these entries since 8.5 (used for JDK17/21) does not run under JDK 25. is_latest moves from node22-jdk21 to node24-jdk25. Refs UIA-415009
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
node20-jdk25,node22-jdk25,node24-jdk25entries toversions/versions.json, pointing at the already-publishedghcr.io/ringcentral-docker/node:*-jdk25base image tags.gradle_versionto9.7.1for the new entries — Gradle 8.5 (used for the JDK17/21 tier) does not run under JDK 25, and early Gradle 9.x releases had a JDK 25 compatibility regression (Gradle 9.1.0+ says Java 25 is incompatible gradle/gradle#35062).is_latestfromnode22-jdk21tonode24-jdk25.Dockerfile/scripts/CI changes needed — the build matrix and README table are generated fromversions/versions.jsonautomatically.Verification
Local build of
node24-jdk25passed, confirming JDK 25.0.1 + Gradle 9.7.1 + Sonar Scanner 6.2.1.4610 + Maven all work together with no compatibility errors:Test plan
docker build/docker runsanity check fornode24-jdk25(java/javac/mvn/gradle/sonar-scanner versions print cleanly)Refs UIA-415009