Feat/optimize zustand store initial state#449
Open
Imole203 wants to merge 3 commits into
Open
Conversation
- Extract theme into useUiStore (AsyncStorage, not SecureStore) - Remove theme/setTheme from useAppStore; appStore is now auth-only - Lazy-initialize achievementStore: start with [] and seed defaults on first loadAchievements() call instead of at store creation - Update useAdaptiveTheme, MobileSettings, Settings to use useUiStore - Update tests/store.test.ts setTheme suite to target useUiStore - Fix pre-existing ESLint import/order and component-definition warnings Closes rinafcode#5 rinafcode#6 rinafcode#29
- Remove barrel re-exports from store/index.ts (notificationStore, courseProgressStore, uiStore) to prevent eager initialization when only useAppStore is needed - Remove dead DEFAULT_SETTINGS constant in settingsStore (duplicate of INITIAL_STATE, never referenced)
Contributor
|
Kindly resolve conflict and workflow. |
|
@Imole203 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
perf: Optimize Zustand store initial state to reduce memory footprint
Summary
Audited all Zustand stores and removed two sources of unnecessary eager
initialization at startup.
Changes
courseProgressStore, and uiStore. These caused all three stores to be
instantiated the moment useAppStore was imported (e.g. in auth.ts), even when
only auth state was needed. Each store is now initialized on-demand when first
imported by a consumer.
15-field object that duplicated INITIAL_STATE but was never referenced
anywhere).
What was already correct
loadAchievements() — store starts with achievements: []
updates required
Testing
All 115 existing tests pass across 6 suites (notificationStore, settingsStore,
quizStore, auth, store).
Closes #262