Perf/remove clipped subviews#445
Open
Faromzy wants to merge 3 commits into
Open
Conversation
Unmounts off-screen items in DownloadQueue, ConnectionManager, and MobileSearch to reduce native view count and improve scroll performance. VirtualList, TopicFeed, and AdvancedDataGrid already had this set.
Unmount off-screen items to reduce native view count during scroll. Targets ~95% reduction in mounted views (500+ to 20-30). Also fix pre-existing ESLint errors: - Fix unescaped apostrophes in MobileProfile and MobileLogin - Fix incorrect @/src/* import aliases in app/(tabs)/index.tsx
|
@Faromzy Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
kindly resolve conflict and fix workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
perf: Enable removeClippedSubviews on ScrollView and FlatList
Summary
Adds removeClippedSubviews={true} to all scrollable list components to unmount
off-screen items from the native view hierarchy, reducing memory pressure and
improving scroll performance.
Changes
SubscriptionManager, MobileSettings, MobileCourseViewer, NotificationSettings,
QuizCarousel, MobileRegister, MobileLogin, MobileSyllabus, FilterSheet,
QuizResults, MobileQuizManager, MobileQuestionCard, AchievementBadges,
GridFiltering, AdvancedDataGrid, app/(tabs)/index
Intentionally skipped:
the parallax animation
Also fixes two pre-existing ESLint errors that were blocking the commit:
Performance Impact
┌────────┬────────┬────────────────┐
│ Metric │ Before │ After (target) │
├────────────────────────────┼────────┼────────────────┤
│ Native views during scroll │ 500+ │ 20–30 │
├────────────────────────────┼────────┼────────────────┤
│ Reduction │ — │ ~95% │
└────────────────────────────┴────────┴────────────────┘
Testing
closes Optimize ScrollView/FlatList rendering with removeClippedSubviews #250