refactor(settings): optimize Zustand selectors and enforce strict Set…#442
Merged
RUKAYAT-CODER merged 2 commits intoMay 28, 2026
Merged
Conversation
…tingsPicker type safety
|
@AlphaMaleBaDI Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
kindly resolve conflict and fix workflow. |
Author
|
Conflicts with upstream |
Contributor
|
LGTM. thank you for your contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #220
Summary
This PR optimizes the application's Zustand store subscriptions by replacing broad store destructuring with granular, field-specific selectors to minimize component re-renders. Additionally, it strengthens the type safety boundaries of the mobile settings selection UI.
Changes Made
src/store/selectors.tsfor individual state fields (useTheme,useUser,useIsAuthenticated, etc.) and a reference-stable hook for action dispatchers (useAppActions).SettingsPickerto be generic (SettingsPicker<T extends string>), allowing string union types likeProfileVisibility,DownloadQuality, and"light" | "dark"to propagate natively without type assertions or generic string leaks.MobileSettingsand settings pages to consume the new granular hooks and use strictly typed options lists.Performance Impact
shallowfunctions in the actions hook, improving compatibility and avoiding unnecessary updates since store actions maintain reference stability across renders.Notes
While verifying these optimizations locally, several unrelated native module compilation warnings and Expo Go environment exceptions were encountered (involving
react-native-nitro-modules,expo-dev-client, andexpo-barcode-scanner). These are pre-existing upstream repository issues and do not impact or relate to the store optimization changes introduced in this PR.Verification
npx tsc --noEmit