feat: add privacy-safe request fingerprinting with deduplication and analytics integration#665
Open
AlienScroll78 wants to merge 1 commit into
Open
Conversation
- FingerprintService: SHA-256 hash generation with IP subnet truncation (IPv4 /24, IPv6 /48) - FingerprintInterceptor: in-memory TTL deduplication + analytics integration via APP_INTERCEPTOR - FingerprintModule wired into AnalyticsModule, AnalyticsModule added to AppModule - Privacy: full IP never stored, hash is one-way, x-forwarded-for subnet-truncated - 18 unit tests (13 service, 5 interceptor)
|
@AlienScroll78 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: Request Fingerprinting for Analysis
Adds privacy-safe request fingerprinting to identify and deduplicate unique request patterns
for analytics.
What's changed
IP subnet, user-agent, and accept-language. Exposes a windowedKey() helper for time-bucketed
deduplication.
1-minute window using an in-memory TTL map, fires AnalyticsService.recordEvent('request',
'fingerprint', path) on first occurrence, and attaches req.fingerprintHash for downstream use.
Privacy guarantees
Testing
18 unit tests covering: hash determinism, subnet truncation, IPv4/IPv6/forwarded-IP handling,
missing header edge cases, deduplication within a window, and separate event recording for
distinct fingerprints.
Also fixes a pre-existing issue where @types/jest was missing from tsconfig.json, causing all
spec files to fail type-checking.
close #654