feat(#651): implement request decompression handling#657
Open
Gozirimdev wants to merge 4 commits into
Open
Conversation
- Add DecompressionMiddleware to handle gzip, brotli, and deflate compression - Implement Content-Encoding header detection and processing - Add comprehensive unit tests with multiple compression format coverage - Support case-insensitive encoding detection - Include error handling for decompression failures - Integrate middleware into main application bootstrap - Add detailed documentation on usage and configuration Acceptance Criteria: ✅ Gzip decompression ✅ Brotli decompression ✅ Deflate decompression ✅ Content-Encoding header handling The middleware: - Uses Node.js built-in zlib module (no external dependencies) - Automatically decompresses request payloads based on Content-Encoding header - Removes Content-Encoding header after decompression - Gracefully handles errors with HTTP 400 responses - Passes through uncompressed or unsupported encoding requests - Skips GET, HEAD, and DELETE requests (no body expected)
|
@Gozirimdev Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
- Rename bootstrap to bootstrapWorker for clarity - Add cluster mode support with primary/worker process handling - Add graceful shutdown handling with configurable timeout - Remove redundant comments for cleaner code - Preserve DecompressionMiddleware integration
- Remove unnecessary variable tracking in middleware - Fix type inference for error parameters - Use proper Error type handling with instanceof checks - Remove unused imports from test file - Use PassThrough from stream import instead of require - Simplify stream piping to avoid circular references - Fix shadowed variable name in transform function - Improve error handling with proper type checking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #651
Acceptance Criteria:
✅ Gzip decompression
✅ Brotli decompression
✅ Deflate decompression
✅ Content-Encoding header handling
The middleware:
Linked Issue
Closes #N
What does this PR do?
Type of change
Pre-merge checklist (required)
Branch & metadata
feature/issue-<N>-<slug>/fix/issue-<N>-<slug>conventiondevelopormain)Code quality & tests
npm run lint:ci— zero ESLint warningsnpm run format:check— Prettier reports no changes needednpm run typecheck— zero TypeScript errorsnpm run test:ci— all tests pass, coverage ≥ 70%.spec.tsunit testsError handling & NestJS best practices
class-validator/class-transformerdecorators and are wired through NestJS pipes (e.g. globalValidationPipeor explicit)any/unknownreaching the domain)BadRequestException,UnauthorizedException,ForbiddenException,NotFoundException) instead of genericErrorLoggeror central logger service) with meaningful, structured messagesAuthGuard, role/permissions guards, custom guards) are applied to all new/modified endpoints where appropriateAPI documentation / Swagger
/api(or Swagger UI) reflects new/changed endpoints correctlyBreaking changes
Breaking change description (if applicable)
Test evidence (required)
Commands run locally
Manual / API verification
Screenshots / recordings (if applicable)