Conversation
tonyespy
left a comment
tonyespy
left a comment
There was a problem hiding this comment.
Per our discussion the other day, let's merge and/or push this into a separate branch for now.
Also didn't see any changes for the ubuntu-apndn plugin?
| char *filename; | ||
|
|
||
| snap = getenv("SNAP"); | ||
| filename = g_strdup_printf("%s%s", snap ? snap : "", MBPI_DATABASE); |
There was a problem hiding this comment.
We should discuss where mbpi ends up living as it's used by modemmanager too.
I think it probably should live in it's own snap that shares the file via content sharing. We also should explore the ability for an end-user to modify this file on a working system ( ie. allow a writable version that would override the default ) vs. forcing the user to report a bug and wait for an official update.
| gboolean ret = FALSE; | ||
| const char *snap; | ||
| char *filename; | ||
|
|
There was a problem hiding this comment.
Please add a short comment that explains the SNAP env variable.
| const char *filename; | ||
| char *snap_filename = NULL; | ||
| const char *conf_override = getenv("OFONO_PHONESIM_CONFIG"); | ||
| const char *snap_common = getenv("SNAP_COMMON"); |
There was a problem hiding this comment.
Please add a short comment explaining why SNAP_COMMON is used here.
|
|
||
| g_key_file_free(keyfile); | ||
| } | ||
|
|
There was a problem hiding this comment.
Please add a short comment here describing the purpose of this function, and why SNAP_COMMON is used.
|
Might as well add some extra logic to plugins/u8500.c, as it won't be possible for a user to add the file /etc/imei. |
alfonsosanchezbeato
force-pushed
the
snappy-env-vars
branch
from
386e60c to
94d7420
Compare
|
Branch refreshed after addressing comments. Some points:
|
2 participants
Add support for snappy by checking env vars to know where to store/find data files.