Repository navigation
PSF calibration: says where the pupil model learns, and warns of a CPU-only PyTorch beside an NVIDIA card - #165
Merged
Merged
Conversation
…eplaces it The plugin (Localize/Bead calibration), its window (calibrate/qt_gui.py), its assistant actions and its pages are removed. The bead average is the PSF calibration window's, which already had every page, the bead table and the assistant's actions; its method's explanation moves to a widgetless help page, Panels/Bead average. smappy-calibrate opens the PSF calibration window (headless --out unchanged). The tests of the use_calibration hand-over and of the bead settings' forms are kept. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014JegwAEzHHExiXkwvXgA2j
…est tested on the minimal pupil From round 2, once the coverslip edge has set the focus, a unit localised more than 3 errors below the coverslip (its CRLB times the edge's scatter factor, with the edge's own error) is not chosen (`insitu_rounds.below_coverslip`, `RoundSettings.below_coverslip_sd`): the z bins below 0 had filled with molecules the model placed badly. The twin test already mirrored held modes; a test now pins it for the minimal pupil, in situ's default. The roadmap's in situ line and the architecture's known flaws brought up to date. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014JegwAEzHHExiXkwvXgA2j
…U-only PyTorch beside an NVIDIA card The line Detect writes now ends with where learning runs (uipsf.device.describe: the graphics card by name, Apple's GPU or the CPU). A torch built for the CPU only on a machine with an NVIDIA card (torch_install.cpu_build_on_nvidia, from its version's local label: a plain pip install on Windows brings it) learnt on the CPU without a word; the window now says so and offers Install PyTorch, whose command then reinstalls the card's build from the CUDA index (command(replace=True)), and asks for a restart where the old build is already loaded. Neither blocks a run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014JegwAEzHHExiXkwvXgA2j
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
uipsf.device.describe, throughpsf_window.learning_device).pip install torchon Windows, whose PyPI wheel is CPU only.torch_install.cpu_build_on_nvidiafinds it from the version's local label, without importing torch.command(replace=True)) reinstalls the card's build from the CUDA 12.6 index: with--force-reinstall --no-depson Windows, through the higher local label on Linux. A plain--upgradewould keep the CPU build.tests/test_torch_install.py.Not yet checked
The replacement install itself has not been run on a real Windows PC with a CPU-only torch.
Tests
--slow -n auto: 4225 passed, 17 failed, 29 errors, 101 skipped. None of the failures is this change's:tests/decode_tests, the DECODE plugin pages): torch was installed for this run but not thedecodeextra, so they fail onModuleNotFoundError: No module named 'tqdm'.test_live_session::test_the_window_hands_the_fits_progress_on_as_numbers,uipsf_tests/test_confocal::test_a_pinhole_wide_open_gives_the_open_detectors_scananduipsf_tests/test_minimal_pupil::test_a_calibration_recovers_gamma_the_saf_damping_and_the_blur_beyond_the_pixel. Each crashed its pytest worker in the full run (4 workers, 15 GB) and passes when run alone: 3 passed in 96 s.Targeted:
test_torch_install,test_panel_docs,uipsf_tests/test_psf_window,test_window_actions,test_calibrate_qt: 53 passed, 18 skipped.Generated by Claude Code