Fix iOS prebuild with Expo SDK 54+ (RCT-Folly / RCT_USE_RN_DEP)

[samuelbeaulieu]

When running expo prebuild on Expo SDK 54+, pod install fails because theta-client-react-native declares a direct dependency on RCT-Folly, which is no longer resolved that way in the new setup.

Error

❯ expo prebuild --clean

✔ Cleared android, ios code
✔ Created native directories
✔ Updated package.json | no changes
About Libraries activity - ADDED
Gradle Plugin Portal repository - ADDED
About Libraries Gradle Plugin repository - ADDED
About Libraries Gradle Plugin - APPLIED
About Libraries Gradle Plugin - CONFIGURED
LicensePlist buildPhase in nativeTarget "PixelGuru" - ADDED
Settings.bundle/Root.plist - ADDED
✔ Finished prebuild
⚠️  Something went wrong running `pod install` in the `ios` directory.
Command `pod install` failed.
└─ Cause: Unable to find a specification for `RCT-Folly` depended upon by `theta-client-react-native`

You have either:
 * mistyped the name or version.
 * not added the source repo that hosts the Podspec to your Podfile.


pod install --repo-update --ansi exited with non-zero code: 1
✨  Done in 25.63s.

Cause

In Expo SDK 54+, React Native sets RCT_USE_RN_DEP=1 and supplies Folly (and related New Architecture deps) itself. This podspec always adds RCT-Folly and sets -DRCT_NEW_ARCH_ENABLED=1 when RCT_NEW_ARCH_ENABLED=1, which conflicts with that and leads to the “Unable to find a specification for RCT-Folly” error.

Fix

Only add the RCT-Folly dependency and the New Architecture compiler flags when RCT_USE_RN_DEP != '1'. When RCT_USE_RN_DEP=1 (Expo SDK 54+), rely on React Native’s Folly and flags. For the case where we do depend on Folly, pin RCT-Folly to folly_version to avoid version mismatches.

Testing

Verified expo prebuild --clean and pod install succeed in an Expo SDK 54 project using the patch.

[samuelbeaulieu]

@LassicYM can we get this released?

[simago]

@samuelbeaulieu Thank you for your report.
We are currently working on supporting React Native's new architecture, and hope to be able to release it in the near future.
The new architecture will introduce the install_modules_dependencies function, which will automatically manage all dependencies, including RCT-Folly.
Therefore, we expect that the processing you suggested will no longer be necessary from the next release onwards.

[samuelbeaulieu]

Ah! That's good news to hear. Thank you for the update! I will keep the patch on my side until full support for the new architecture is released.