chore: drop bundled third-party logos from the empty state - #21
Merged
Merged
Conversation
The two rows under "Getting WebMCP" shipped a product logo each, from public/image/. Those are marks this repo has no licence to redistribute, sitting in the panel that a demo recording of this app necessarily shows. Replaced with generic lucide glyphs in the same family as the section headings, and deleted both files. The product names stay in the text -- naming a browser is not the same as shipping its mark. A comment above the list says so, because the obvious "improvement" is to put them back. Incidental: removing the raw <img> tags also clears the two @next/next/no-img-element lint warnings they carried.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
stage-empty-state.tsxrendered a product logo beside each of the two "Getting WebMCP" rows, loaded fromtraces/public/image/. Those are third-party marks the repository has no licence to redistribute, and they sit in the one panel any recording of this app has to show.What changed
<img>tags become genericlucide-reactglyphs (AppWindow,Globe) styled like the section headings already in the file:size={14} strokeWidth={1.75} className="shrink-0 text-muted".traces/public/image/ChatGPT.webpandChrome.webpdeleted. The directory had nothing else in it, so it is gone too.The product names stay in the row titles. Naming a browser is not the same as shipping its artwork.
Note:
lucide-reactdoes have aChromeicon, and it is deliberately not used here — it is the Chrome logo shape, which would reintroduce exactly what this removes.Verification
npx tsc --noEmit— exit 0npx vitest run— 25 files, 309 tests, all passingnpm run lint— 0 errors, 6 warnings, all pre-existing. Two@next/next/no-img-elementwarnings went away with the<img>tags.