docs: correct claims the code does not support - #17
Merged
Merged
Conversation
Three statements that were not true of the code: - CLAUDE.md said every stub from the original build had been implemented. `registerDynamicTool` is still a stub that throws, nothing calls it, and its marker is still on the line above it. Named, with the consequence stated: promoting a hypothesis does not grow a 17th tool. - CLAUDE.md said "All 285 tests pass". Measured: 25 files, 303 tests. - The `toolchange` comment in tool-status-banner.tsx presented the dynamic registration mechanism as something the app does. It is a stub; the only thing that can move that counter is the host changing its own tool list. No behaviour change. `registerDynamicTool` is left exactly as it is, marker included.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three prose claims that the code does not support. Docs and one comment only — no behaviour change, and
registerDynamicToolis left exactly as it is, marker included.What was wrong, and what it says now
1.
CLAUDE.md— "every stub has been implemented"False in two ways.
traces/src/lib/webmcp/register-tools.ts:133still reads:and the
TODO: Day 6marker is still on line 131, directly above it. A repo-wide grep (excludingnode_modules) finds exactly three references to the symbol: the two definition lines, and one comment intool-status-banner.tsx. Nothing calls it.Now names the stub, says it throws, says nothing calls it, and states the consequence — promoting a hypothesis does not grow a 17th tool. The rest of the section (why markers must not be deleted) is untouched.
2.
CLAUDE.md— the test countMeasured on this branch: 25 files, 303 tests. Updated to 303.
3.
tool-status-banner.tsx— thetoolchangecommentRead as documentation of something the app does. It reads as a conditional now, and says plainly that
registerDynamicToolis a stub that throws with no callers, so the only thing that can move the counter is the host changing its own tool list. The rest of the comment — theEventTargetnote, ChatGPT Desktop, why the count is changes rather than a total — is accurate and unchanged.Everything else was checked and is correct
Every other absolute claim in
CLAUDE.mdandREADME.mdwas verified against the code rather than assumed:registry.ts,register-tools.tsevaluate-predicate.tscompress-dom.ts:16-17compress-dom.ts:19,100scripts/measure-compression.mjspublic/recordings/src/app/fonts.tsdocs/tools.md:579was already fixed and is untouched. The tagline is untouched in all four places.Notes
One drift from the brief. The test-count line is
CLAUDE.md:39, not:37(:37is the section heading). Fixed by content.One understatement left in place, deliberately.
CLAUDE.md:43describesno-eval.test.tsas failing "ifeval(ornew Functionappears anywhere". That is true, but the test enforces five patterns across all oftraces/src, not two — it also catchessetTimeout/setIntervalwith a string first argument and.innerHTMLassignment from anything named likeargs|input|params|predicate|payload. Understated rather than false, so it is reported here rather than rewritten; correcting it properly means rewriting the paragraph, which is a bigger edit than this PR is for.Forward dependency. "does not grow a 17th tool" is correct at 16 tools. If a seventeenth tool lands, that word has to move with the rest of the 16→17 sweep.
Verification