chore: give the tab an icon - #15
Merged
Merged
Conversation
The page is shown inside the ChatGPT in-app browser and in a screen recording, where the tab strip is on camera. The default globe there reads as an unfinished page. The file sits in public/ and layout.tsx names it explicitly through metadata.icons rather than leaning on the app/favicon.ico convention, so the path is visible where the rest of the head is declared. One ICO carrying 16x16 and 32x32. tsc clean, 303 tests green across 25 files.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The page is shown inside the ChatGPT in-app browser and in a screen recording, where the tab strip is on camera. The default globe there reads as an unfinished page.
public/favicon.ico— one ICO carrying 16x16 and 32x32 — plus an explicitmetadata.iconsentry inlayout.tsx, so the path is visible where the rest of the head is declared rather than resolved by theapp/favicon.icofile-name convention.tsc --noEmitclean, 303 tests green across 25 files.