remove unnecessary group_types array and associated methods. - #606
remove unnecessary group_types array and associated methods.#606nickchomey wants to merge 3 commits into
Conversation
…gnored/unflushable_groups are now associative arrays
There was a problem hiding this comment.
Pull request overview
This PR simplifies group-type handling in the object cache by removing the derived group_type mapping and relying on direct group membership checks (via associative arrays + isset()), continuing the performance-oriented direction of #340.
Changes:
- Convert
global_groups,ignored_groups, andunflushable_groupsinto associative lookup structures and useisset()for membership checks. - Remove
cache_group_types()/is_group_of_type()and update callers to use direct group membership helpers. - Adjust selective flush logic to account for the new structure (e.g.,
array_keys()for unflushable groups).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2acb88b to
31f0bbb
Compare
31f0bbb to
3e6e4ef
Compare
|
i admittedly did not test the new test, nor whether the old ones passed - not sure how to actually run them. Do you have any CI tests that do it? Or are you able to run yourself easily? |
|
@tillkruss were you able to look at the tests for this? |
|
@nickchomey I was under the impression that we're waiting on something in SQL object cache to be figured out first, is that one merged? |
|
It hasn't been merged in sqlite object cache either. But it's not clear to me how that is relevant? I'm happy to address anything that remains of concern here |
the performance optimizations introduced with the associative array in #340 didnt actually require adding the group_types array and associated methods. Better to just convert global/ignored/unflushable_groups themselves to associative arrays and use isset on those directly.