Conversation
Auto-detect ROSA clusters via Infrastructure resource tags (red-hat-clustertype: rosa) and use `rosa create idp --type openid` instead of patching the OAuth CRD, which is not supported on ROSA. Changes: - workload.yml: Auto-detect ROSA, fail on htpasswd+ROSA, delete ROSA admin when remove_kubeadmin is true - setup_keycloak.yml: Conditional OAuth integration — OAuth CRD for IPI, rosa create idp for ROSA (delegated to bastion) - remove_workload.yml: Conditional cleanup — OAuth CRD reset for IPI, rosa delete idp for ROSA - defaults/main.yml: Add rosa_cluster_name variable Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
wkulhanek
requested review from
agonzalezrh,
fridim,
rut31337 and
stencell
as code owners
agonzalezrh
previously approved these changes
May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Infrastructureresource tags (red-hat-clustertype: rosa)rosa create idp --type openidinstead of OAuth CRD for Keycloak integration on ROSA (OAuth CRD is not supported on managed ROSA clusters)ocp4_workload_authentication_remove_kubeadmin: truerosa create idp/rosa delete idpcommands are delegated to bastion (ROSA CLI session not available in EE)