fix: retry loop in remove_run_from_status exits without retrying on 422#189
Open
marcosmamorim wants to merge 1 commit into
Open
fix: retry loop in remove_run_from_status exits without retrying on 422#189marcosmamorim wants to merge 1 commit into
marcosmamorim wants to merge 1 commit into
Conversation
The break statement was outside the try block, causing the while loop to exit after a single iteration regardless of success or 422 conflict. On a 422, the subject was refreshed but the removal was never retried, leaving a ghost run reference permanently in status.runs.active. This blocked the FIFO run queue, preventing subsequent runs from being promoted to pending and ultimately preventing subject deletion. Changed to a bounded for loop (matching add_run_to_status pattern) with break inside the try block, so 422 conflicts trigger refresh + retry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
remove_run_from_statusthat silentlydropped run removal on 422 (conflict) responses, creating ghost
run references in
status.runs.activesubsequent runs from executing and blocking subject deletion
add_run_to_status(bounded for-loop with max 10 retries and kopf.TemporaryError)