Standalone tools/build-rpm.sh

[coiby]

Extract the code of building RPM from tools/run-integration-tests.sh as tools/build-rpm.sh so it can be re-used by developers.

Suggested-by: Sourabh Jain sourabhjain@linux.ibm.com

[gemini-code-assist]

Summary of Changes

Hello @coiby, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the development workflow by extracting the RPM building process into a dedicated, reusable script. This change promotes modularity and simplifies how developers can generate kdump-utils RPMs independently. The integration test script now leverages this new utility, streamlining its execution by delegating the RPM build task, which makes the overall build and test process more efficient and maintainable.

Highlights

• New Standalone RPM Build Script: A new script, tools/build-rpm.sh, has been introduced to encapsulate the logic for building kdump-utils RPMs. This script is designed for reusability by developers.
• Automatic Version Detection: The new build-rpm.sh script includes functionality to automatically detect the RPM version based on Git tags (e.g., v1.0.x), falling back to the version specified in kdump-utils.spec if no tags are found.
• Refactored Integration Test Script: The tools/run-integration-tests.sh script has been updated to delegate the RPM building process to the new tools/build-rpm.sh script, removing redundant code and improving modularity.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request extracts the RPM building logic into a new, reusable script tools/build-rpm.sh, which is a great improvement for developer workflows. The new script also introduces a feature to automatically increment the version based on git tags. The implementation is generally well-done. My feedback includes a few suggestions to enhance the script's robustness and clarity, such as using a temporary file for the spec modifications and improving a comment to reflect the new versioning behavior accurately.

[coiby]

Hi @sourabhjains,

Will the proposed tools/build-rpm.sh meet your requirements?