Use example.invalid instead of example.org in kickstart_test tests - #98
Merged
jstodola merged 2 commits intoSep 23, 2026
Merged
Conversation
example.org is a real, publicly reachable domain, so a test that isn't fully mocked can make a genuine outbound HTTP request to it. On networks with an egress firewall that silently drops the connection, this hangs until the job times out instead of failing fast. example.invalid is the RFC 2606 domain guaranteed to never resolve. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
These tests never mocked the boot.iso download, so they only passed because example.org was a real, reachable host that requests.get() didn't raise on. Switching to example.invalid (previous commit) made the unmocked network call fail fast instead of hanging, exposing that these tests aren't meant to perform real I/O. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
jstodola
force-pushed
the
fix/kickstart-test-example-domain
branch
from
September 23, 2026 15:18
034bd4d to
15067c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
example.org is a real, publicly reachable domain, so a test that isn't fully mocked can make a genuine outbound HTTP request to it. On networks with an egress firewall that silently drops the connection, this hangs until the job times out instead of failing fast. example.invalid is the RFC 2606 domain guaranteed to never resolve.