Skip to content

Use tclib.expressions.compile_bool instead of tclib.expressions.eval_bool #2

Description

@pholica

Using the tclib.expressions.eval_bool repeatedly on the same jinja2 expression has effect on the performance. There's https://github.com/rhinstaller/tclib/pull/8 which should improve the situation in the tclib itself.

There are some places in the Permian where the tclib.expressions.eval_bool is used inside loops using the same jinja2 template string which leads to performance issues.

I can see one candidate in run_subset plugin which is worth fixing (especially when there are a lot of CRCs being filtered).

No activity

Activity on this issue will appear here.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions