Skip to content

Skip default Anaconda-webui COPR when --test-copr is used - #1756

Closed
adamkankovsky wants to merge 1 commit into
rhinstaller:mainfrom
adamkankovsky:fix/test-copr-precedence
Closed

adamkankovsky wants to merge 1 commit into
rhinstaller:mainfrom
adamkankovsky:fix/test-copr-precedence

Conversation

@adamkankovsky

Copy link
Copy Markdown
Contributor

The webui-boot.iso build always added the @rhinstaller/Anaconda-webui COPR alongside any --test-copr repo. As dnf selects the best EVR candidate, the usually newer main build silently shadowed the PR package under test, so /test-os-variants --test-copr for an anaconda-webui PR actually tested main.

Only add the default COPR when no custom test COPR is requested.

The webui-boot.iso build always added the @rhinstaller/Anaconda-webui
COPR alongside any --test-copr repo. As dnf selects the best EVR
candidate, the usually newer main build silently shadowed the PR
package under test, so /test-os-variants --test-copr for an
anaconda-webui PR actually tested main.

Only add the default COPR when no custom test COPR is requested.

@KKoukiou KKoukiou left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This --test-copr is not only relevant for WebUI. Also PR builds should be when rebased always newer compared to main builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants