Skip to content

Re-enable luks/encrypted tests on daily-iso-webui (gh1715) - #1742

Merged
adamkankovsky merged 1 commit into
rhinstaller:mainfrom
adamkankovsky:fix/re-enable-gh1715-tests
Sep 21, 2026
Merged

adamkankovsky merged 1 commit into
rhinstaller:mainfrom
adamkankovsky:fix/re-enable-gh1715-tests

Conversation

@adamkankovsky

Copy link
Copy Markdown
Contributor

The fix for gh1715 was merged in anaconda-webui#1431: GetDiskFreeSpace and GetDiskTotalSpace are now only called for disk devices, guarded by devData["is-disk"].v.

Remove the gh1715 testtype from the affected tests and from the daily_iso_webui_disabled_array.

@adamkankovsky

Copy link
Copy Markdown
Contributor Author

/test-os-variants

@rvykydal

Copy link
Copy Markdown
Contributor

@adamkankovsky: Not sure if you know, it is now possible to run the tests only on variant of interest, like:

/test-os-variants --os-variants daily-iso-webui

@adamkankovsky

Copy link
Copy Markdown
Contributor Author

@adamkankovsky: Not sure if you know, it is now possible to run the tests only on variant of interest, like:

/test-os-variants --os-variants daily-iso-webui

Oh, thanks, that helps a lot

@adamkankovsky
adamkankovsky force-pushed the fix/re-enable-gh1715-tests branch from 048712b to 6a26f57 Compare August 31, 2026 11:52
@adamkankovsky

Copy link
Copy Markdown
Contributor Author

/test-os-variants --os-variants daily-iso-webui

@adamkankovsky
adamkankovsky force-pushed the fix/re-enable-gh1715-tests branch from 6a26f57 to c0b6534 Compare September 1, 2026 07:14
@adamkankovsky

Copy link
Copy Markdown
Contributor Author

/test-os-variants --os-variants daily-iso-webui

@adamkankovsky
adamkankovsky force-pushed the fix/re-enable-gh1715-tests branch from c0b6534 to d39d4b2 Compare September 2, 2026 11:50
@adamkankovsky

Copy link
Copy Markdown
Contributor Author

/test-os-variants --os-variants daily-iso-webui

@adamkankovsky
adamkankovsky force-pushed the fix/re-enable-gh1715-tests branch from d39d4b2 to b768af1 Compare September 14, 2026 06:06
@adamkankovsky

Copy link
Copy Markdown
Contributor Author

/test-os-variants --os-variants daily-iso-webui

@adamkankovsky
adamkankovsky force-pushed the fix/re-enable-gh1715-tests branch from b768af1 to d693d31 Compare September 16, 2026 07:04
@adamkankovsky

Copy link
Copy Markdown
Contributor Author

/test-os-variants --test-copr=packit/rhinstaller-anaconda-webui-1474 --os-variants=daily-iso-webui

1 similar comment
@adamkankovsky

Copy link
Copy Markdown
Contributor Author

/test-os-variants --test-copr=packit/rhinstaller-anaconda-webui-1474 --os-variants=daily-iso-webui

The fix for gh1715 was merged in anaconda-webui#1431:
GetDiskFreeSpace and GetDiskTotalSpace are now only called for disk
devices, guarded by devData["is-disk"].v.

Remove the gh1715 testtype from the affected tests and from the
daily_iso_webui_disabled_array.

Assisted-by: claude-sonnet-4-6
@adamkankovsky
adamkankovsky force-pushed the fix/re-enable-gh1715-tests branch from d693d31 to 6d2b958 Compare September 18, 2026 08:11
@adamkankovsky

Copy link
Copy Markdown
Contributor Author

/test-os-variants --test-copr=packit/rhinstaller-anaconda-webui-1474 --os-variants=daily-iso-webui

1 similar comment
@adamkankovsky

Copy link
Copy Markdown
Contributor Author

/test-os-variants --test-copr=packit/rhinstaller-anaconda-webui-1474 --os-variants=daily-iso-webui

@adamkankovsky

Copy link
Copy Markdown
Contributor Author

/test-tmt

@rvykydal rvykydal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you.

@adamkankovsky
adamkankovsky merged commit 3d6cd95 into rhinstaller:main Sep 21, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants