Skip to content

Update deposit-service OpenAPI spec#109

Open
Destiner wants to merge 1 commit into
mainfrom
update/deposit-processor
Open

Update deposit-service OpenAPI spec#109
Destiner wants to merge 1 commit into
mainfrom
update/deposit-processor

Conversation

@Destiner
Copy link
Copy Markdown
Contributor

@Destiner Destiner commented May 18, 2026

This PR updates the OpenAPI spec generated from rhinestonewtf/deposit-service-processor@a5b8605223b23e08b9858a423ec4f12c4fd2ce1a.

Copy link
Copy Markdown

@rhinestone-kevin rhinestone-kevin Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve — adds deposits-scope 403 responses; no blockers found.

Copy link
Copy Markdown

@greg-rhinestone greg-rhinestone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Greg · ✅ LGTM

Regenerates the deposit-service spec from rhinestonewtf/deposit-service-processor@690e44e, adding deposits-scope 403 responses across the affected account/deposit endpoints. This matches the upstream key-scope enforcement surface.

Risk: Low — generated spec-only change documenting additive auth errors

@Destiner Destiner force-pushed the update/deposit-processor branch from 019bee9 to a7cbe81 Compare May 18, 2026 10:23
Copy link
Copy Markdown

@rhinestone-kevin rhinestone-kevin Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve — updates deposit-service OpenAPI spec; no blockers found.

@Destiner Destiner force-pushed the update/deposit-processor branch from a7cbe81 to 410e99f Compare May 18, 2026 10:24
Copy link
Copy Markdown

@rhinestone-kevin rhinestone-kevin Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial change — approved without a full review.

Copy link
Copy Markdown

@greg-rhinestone greg-rhinestone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Greg · 🔄 Re-review · ✅ LGTM

No effective deposit-service.json change since the last Greg review; the current generated spec still contains the already-reviewed deposits-scope 403 response coverage.

@Destiner Destiner force-pushed the update/deposit-processor branch from 410e99f to 6337692 Compare May 18, 2026 14:09
Copy link
Copy Markdown

@rhinestone-kevin rhinestone-kevin Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve — updates deposit-service OpenAPI spec; no blockers found.

Copy link
Copy Markdown

@greg-rhinestone greg-rhinestone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Greg · 🔄 Re-review · ✅ LGTM

Generated deposit-service spec now includes the deposits-scope 403 response on the remaining account, deposit, withdrawal, and webhook endpoints from rhinestonewtf/deposit-service-processor@6f83c1a. No new compatibility issue surfaced.

@Destiner Destiner force-pushed the update/deposit-processor branch 2 times, most recently from a2189ba to 10c746c Compare May 19, 2026 12:34
Copy link
Copy Markdown

@rhinestone-kevin rhinestone-kevin Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial change — approved without a full review.

…t-service-processor@a5b8605223b23e08b9858a423ec4f12c4fd2ce1a
@Destiner Destiner force-pushed the update/deposit-processor branch from 10c746c to b4ebe5b Compare May 19, 2026 16:42
Copy link
Copy Markdown

@rhinestone-kevin rhinestone-kevin Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial change — approved without a full review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants