Skip to content

fix(OwnableValidator): bump checknsignatures to revert-4-fix #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
highskore wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(OwnableValidator): bump checknsignatures to revert-4-fix #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"dependencies": {
"@erc7579/enumerablemap4337": "github:erc7579/enumerablemap",
"@openzeppelin/contracts": "^5.3.0",
"@rhinestone/checknsignatures": "github:rhinestonewtf/checknsignatures",
"@rhinestone/checknsignatures": "github:rhinestonewtf/checknsignatures#revert-4-fix/checknsignatures",
Copy link
Copy Markdown

@greg-rhinestone greg-rhinestone Apr 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pin is also what pulls in the newer @rhinestone/sentinellist, and the PR notes say that version breaks OwnableExecutor because popAll() now leaves the list looking initialized. Since this merges to main, we would be landing a known regression outside OwnableValidator just to prep the redeploy. Please either pin/override the old sentinellist here or vendor the checkNSignatures fix so the repo stays green.

"@rhinestone/flatbytes": "github:rhinestonewtf/flatbytes",
"@rhinestone/modulekit": "^0.5.9",
"FreshCryptoLib": "github:rdubois-crypto/FreshCryptoLib",
Expand Down
56 changes: 32 additions & 24 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.