fix: use alchemy rpc#43
Open
highskore wants to merge 2 commits into
Open
Conversation
greg-rhinestone
left a comment
There was a problem hiding this comment.
🤖 Automated review by Greg
PR Review
Summary: Adds an Alchemy RPC utility (src/utils/rpc.ts) with a chain-slug lookup table and falls back to viem's default public RPC when no API key or unsupported chain is encountered. Replaces bare http() calls across main.ts and tokens.ts with the new rpcTransport helper.
Risk: Low — purely improves RPC reliability; fallback preserves existing behaviour.
Suggestions:
getRpcUrlreturns an empty string''for the fallback case and thenrpcTransportcallshttp('')which technically works but is a bit odd. Returningnull | stringand branching on that (already done inrpcTransport) is cleaner — worth making the empty-string sentinel explicit in the comment.- No chain slug entries for testnets (Sepolia, Base Sepolia, etc.). If this tool is used in dev/staging against testnets those calls will silently fall back to public RPCs. Fine for now, but worth a TODO comment.
Missing: Nothing critical.
Verdict: LGTM ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.