Repository navigation
Feat/ps audio video streaming - #12
Merged
Merged
Conversation
…s-audio-video-streaming
…s-audio-video-streaming Keep origin/dev LAW and ECOSYSTEM stubs; drop generated tsbuildinfo from the merge. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds SRT subtitle upload and display for video and audio assets in admin, plus
subtitletype/format filters.Why
Video and audio assets had thumbnail upload but no way to attach captions. Admins needed to upload an SRT, see it on detail/edit, and filter subtitle assets in the list.
Changes
POST /v1/admin/assets/:id/subtitle/upload(same multipartfileflow as thumbnail)IChildAssetforthumbnailandsubtitle(id,url,status,size_bytes).srtonly, existing non-video 10 MB limit)subtitleto asset type and format dropdowns (create/edit type and list filters)AdminAssetController.uploadSubtitleunit tests (success with nested subtitle, failure)README.mdandECOSYSTEM.mdfor subtitle upload, display, filters, and API routesTesting
This change was verified by...
npx vitest run src/modules/admin/asset/asset.controller.test.ts— 17 passed.Manual: on a video or audio asset edit page, upload a valid
.srtunder the non-video size limit and confirm the subtitle row appears on edit and detail. Confirm a non-SRT or oversized file is rejected. Confirm list filters include Type = Subtitle and Format = Subtitle.Related Issues
Screenshots / Videos
Notes
UPLOAD_SIZE_LIMITS.MAX_NON_VIDEO_SIZE_MB(default 10, fromVITE_MEDIA_MAX_NON_VIDEO_SIZE_MB).POST /v1/admin/assets/:id/subtitle/upload.Checklist