Merge pull request #279 from ahumbert/fix/account-menu-logout-closes-connection fix(account): close the connection when logging out of the account menu

.github/workflows/ci.yml

@@ -0,0 +1,51 @@
+name: CI
+
+on:
+  push:
+    branches:
+      - master
+  pull_request:
+    branches:
+      - master
+
+permissions:
+  contents: read
+
+jobs:
+  build-test-smoke:
+    name: Build, Unit Tests, and Smoke Tests
+    runs-on: ubuntu-24.04
+    timeout-minutes: 30
+
+    steps:
+      - name: Check out repository
+        uses: actions/checkout@v4
+        with:
+          persist-credentials: false
+
+      - name: Install system dependencies
+        run: |
+          sudo apt-get update
+          sudo apt-get install -y \
+            build-essential \
+            clang-format \
+            cmake \
+            cargo \
+            gcc-multilib \
+            g++-multilib \
+            libc6-dev-i386 \
+            libcrypt-dev \
+            libgtest-dev \
+            make \
+            pkg-config \
+            python3 \
+            rustc
+
+      - name: Configure build tree
+        run: make configure
+
+      - name: Run C++ unit tests
+        run: make test
+
+      - name: Run account smoke flow
+        run: make smoke-account

.gitignore

@@ -47,14 +47,18 @@ CVS/
 old/
 backup/
 lib/misc/plrmail
+lib/accounts/
 lib/misc/maze.dat
 lib/misc/mdl
 lib/misc/mudlle.keys
 lib/misc/oldcrimelist
 lib/misc/pk*
 lib/misc/repair*
+lib/misc/xnames*
+tools/__pycache__/
 core/
 *~
+autorun
 autorun4000
 switchserver.sh
 crashes
@@ -77,3 +81,8 @@ target/
 
 # cmake
 .cache
+cmake_test_discovery*.json
+
+# macOS
+.DS_Store
+**/.DS_Store

AGENTS.md

@@ -8,25 +8,52 @@
 - proxy/: Rust workspace member (`cargo` crate) for proxy/CLI utilities.
 - release-notes/, game design docs/, code documentation/: Docs and release history.
 
+## Planning Workflow
+- Before starting feature work, always read `FEATURES.md` and `WIP.md` if they exist.
+- Treat `FEATURES.md` as the current feature scope, breakdown, and implementation checklist.
+- Treat `WIP.md` as the current execution log and update it during feature work with the current task, recent progress, and next step.
+- If feature scope changes during discussion, update `FEATURES.md` before implementing.
+- If active work changes during implementation, update `WIP.md` before continuing.
+
 ## Build, Test, and Development Commands
-- Bootstrap data: `cd src && make setup` — creates required runtime directories/files under `lib/`, `log/`, and `bin/`.
-- Build (Make): `cd src && make all` — compiles C/C++ sources to `bin/ageland`.
-- Run: `cd src && make run` or `./bin/ageland -p &` — starts server in background.
-- Clean: `cd src && make clean` — removes `*.o` objects.
-- CMake alt build: `cmake -S src -B build && cmake --build build` (C++17).
+- Configure: `make configure` — generates the CMake build tree in `build/`.
+- Bootstrap data: `make setup` — creates required runtime directories/files under `lib/`, `log/`, and `bin/`.
+- Build: `make build` — compiles C/C++ sources to `bin/ageland`.
+- Test: `make test` — builds and runs the GoogleTest-based C++ unit tests.
+- Manual smoke: `make smoke-account` — builds the game/proxy and runs the proxy-backed account smoke flow.
+  Use this as a required separate validation step for account/login/authentication changes because `make test` is intentionally unit-test-only.
+- Run: `make run` — builds and starts the server in the foreground on port `3791`.
+- Clean: `make clean` — removes build outputs from the configured tree.
+- Raw CMake fallback: `cmake -S src -B build -DCMAKE_CXX_COMPILER=g++ && cmake --build build --target ageland`
 - Rust proxy: `cargo build -p proxy` | `cargo test -p proxy` | `cargo run -p proxy -- --help`.
 
 ## Coding Style & Naming Conventions
-- Formatter: run `cd src && make format` (WebKit style). Prefer this over local defaults; CI expects formatted diffs.
+- Formatter: run `cmake --build build --target format` (or `cd src && make format`) using WebKit style. Prefer the repo-provided target over local defaults; CI expects formatted diffs.
 - .clang-format: present for IDEs; indentation 4 spaces; column limit ~100.
 - Filenames: lower_snake_case for `.cpp`/`.h` (e.g., `act_comm.cpp`, `protocol.h`).
 - C/C++: functions/variables lower_snake_case; constants UPPER_SNAKE_CASE; types TitleCase where applicable.
 - Rust (proxy): follow `rustfmt` defaults; module/file lowercase with underscores.
 
 ## Testing Guidelines
-- C/C++: no formal unit tests; perform smoke tests by building and running locally. Verify server boots, accepts connections, and changed features behave as expected.
+- C/C++: add or update unit tests in `src/tests/` when working in covered areas, run them via `make test`, and also perform smoke tests manually by building and running locally, typically via `make smoke-account` for the account flow. For account/login/authentication changes, treat that smoke run as a required separate validation step before finalizing. Verify server boots, accepts connections, and changed features behave as expected.
+- When the user reports a bug or finding, default to adding a focused unit/regression test for it first whenever the affected area is unit-testable. If a meaningful unit test is not practical, say so explicitly and add the next-best automated coverage you can.
+- C/C++ test style: prefer behavior-oriented GoogleTest names that read clearly in CTest output, such as `ReturnsConfiguredWeaponType` instead of terse names like `WeaponType`. Use readable assertions like `EXPECT_TRUE` when appropriate, and add concise failure messages that explain the expectation and include important domain values when a failure would otherwise be cryptic.
+- Do not modify production code solely to accommodate tests. Prefer test fixtures, helper builders, dependency-free coverage, and existing public behavior. Only introduce a production seam for testability when it is also a legitimate design improvement, and call that out explicitly.
+- New code: add unit tests for newly written code when the surrounding module supports them, and document any gaps when tests are not practical.
+- When writing or expanding unit tests for non-trivial code paths, maintain a constructively adversarial test-design partner named `Bazarat`. Use `Bazarat` to challenge assumptions, look for missing edge cases, identify weak assertions, and pressure-test whether the tests would catch realistic regressions instead of only happy paths.
 - Rust: write unit/integration tests in `proxy/`; run with `cargo test -p proxy` and keep coverage reasonable.
 
+## Review Workflow
+- Before finalizing any non-trivial change set, maintain two review subagents in parallel: `Magus` as the quality engineer reviewer and `Vincent` as the security engineer reviewer.
+- When the change set includes meaningful unit-test work, keep `Bazarat` engaged during test design and test review as a constructively adversarial pairing partner in addition to the normal reviewer pair. `Bazarat` is not a replacement for `Magus` or `Vincent`; the role is to pressure-test test intent, edge coverage, and failure realism while the code is still being written.
+- Reuse the same reviewer pair across successive changes by sending them updated diff context, instead of spawning a fresh pair for every round. Only replace a reviewer when it has been closed, becomes unavailable, or its context is no longer reliable. If either reviewer must be replaced, assign the replacement the same role name so the workflow stays consistent.
+- In user-facing updates, always refer to the reviewer roles as `Magus` and `Vincent`, and the test-design partner role as `Bazarat`, even if the underlying subagent identity has changed, so the review trail stays clear and consistent.
+- The quality engineer should focus on regressions, correctness, maintainability, test quality, developer ergonomics, and documentation gaps.
+- The security engineer should focus on trust boundaries, unsafe execution paths, secrets or data exposure, command safety, and build/test workflow risks.
+- `Bazarat` should focus on adversarial test questions such as: what assumption is unproven, what malformed input is untested, what rollback path is uncovered, what assertion is too weak, and what realistic regression would still slip through the current tests.
+- Give both reviewers the relevant changed files or diff context, ask for findings first with severity, file references, and concrete recommendations, and do not treat the work as complete until their feedback has been reviewed.
+- Address their findings in code or docs when appropriate, or explicitly document why a recommendation is being deferred.
+
 ## Commit & Pull Request Guidelines
 - Commits: concise, imperative subject (<=72 chars). Reference issues/PRs, e.g., "ranger: fix stun timing (#255)".
 - Scope small, logically grouped changes; include short body for context when needed.
@@ -36,4 +63,3 @@
 ## Security & Configuration
 - World files live in a separate repo; keep `lib/world/` and player data out of commits.
 - Never check in PII or live server logs (`log/`). Use local testing accounts and sanitized samples.
-

Dockerfile

@@ -7,10 +7,11 @@
 # Build/run with docker compose (see docker-compose.yml) or scripts/rots-docker.sh.
 FROM --platform=linux/386 i386/debian:bullseye
 
-# g++ 10 (supports the Makefile's -std=c++1z) + make. The Makefile links no extra
-# libraries, so no other build deps are needed. telnet/procps are dev conveniences.
+# g++ 10 (supports -std=c++1z/c++17) + make. The CMake build (src/CMakeLists.txt) also
+# needs cmake, GoogleTest (libgtest-dev) for the ageland_tests suite, and libcrypt-dev for
+# the crypt() link; pkg-config is a CMake convenience. telnet/procps are dev conveniences.
 RUN apt-get update && apt-get install -y --no-install-recommends \
-        g++ make telnet procps ca-certificates \
+        g++ make cmake libgtest-dev libcrypt-dev pkg-config telnet procps ca-certificates \
     && rm -rf /var/lib/apt/lists/*
 
 WORKDIR /rots