Creating new TRestRadialStrippedMask - #526
Merged
Merged
Conversation
for more information, see https://pre-commit.ci
jgalan
marked this pull request as ready for review
June 14, 2024 07:31
juanangp
approved these changes
Jun 14, 2024
jovoy
reviewed
Jun 14, 2024
|
|
||
| TVector2 point(x, y); | ||
| Double_t phi = point.Phi(); | ||
|
|
Contributor
There was a problem hiding this comment.
So one thing that we still need for this is the initialRadius like in the TRestSpiderMask. Does this mean that X-rays hitting inside the initialRadius are stopped? And then if you use internalRegionRadius they pass in that region? If I understood that correctly we would also need internalRegionRadius because some of the Spacers only start at the halfway mark of the radii.
Member
Author
There was a problem hiding this comment.
Ok, I have updated accordingly to follow the same logic as TRestSpiderMask. I updated the image on the documentation, and added also in the description of this PR. Watch out the masks.rml file.
…ework into jgalan_radial_good
for more information, see https://pre-commit.ci
jovoy
approved these changes
Jun 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new type of radial mask that will be required by new custom optics rest-for-physics/axionlib-data#11