Skip to content

release: v1.0.4 + fix write_firstrun_report version stamp #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tangym merged 2 commits into from
Aug 15, 2026
+9 −5
Merged

release: v1.0.4 + fix write_firstrun_report version stamp #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28af5f9
fix(version): stop hardcoding v1.0.0-rc1 in write_firstrun_report
tangym Aug 15, 2026
6ba5574
chore(release): bump ACTION_VERSION to v1.0.4
tangym Aug 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/_version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,4 @@
tests/test_action_version.py fails if the two consumers ever disagree again.
"""

ACTION_VERSION = "v1.0.3"
ACTION_VERSION = "v1.0.4"
5 changes: 4 additions & 1 deletion scripts/write_firstrun_report.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,10 @@
import sys
from pathlib import Path

ACTION_VERSION = "v1.0.0-rc1"
try:
from _version import ACTION_VERSION
except ImportError: # invoked as a module rather than a script
from scripts._version import ACTION_VERSION


def _find_file(root: Path, name: str) -> Path | None:
Expand Down
7 changes: 4 additions & 3 deletions tests/test_action_version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ def test_both_report_writers_agree() -> None:

assert load("compare_runs").ACTION_VERSION == expected
assert load("detect_test_set_drift").ACTION_VERSION == expected
assert load("write_firstrun_report").ACTION_VERSION == expected


def test_version_matches_the_newest_release_tag() -> None:
Expand Down Expand Up @@ -70,6 +71,6 @@ def test_version_matches_the_newest_release_tag() -> None:

def test_the_stamp_actually_reaches_a_gate_report() -> None:
"""A constant nothing writes out would pass every check above and still be useless."""
source = (ROOT / "scripts" / "compare_runs.py").read_text(encoding="utf-8")

assert '"action_version": ACTION_VERSION' in source
for name in ("compare_runs", "write_firstrun_report"):
source = (ROOT / "scripts" / f"{name}.py").read_text(encoding="utf-8")
assert '"action_version": ACTION_VERSION' in source, name
Loading