feat: new promise id format (':' lineage separator, drop id prefix) - #11
Open
Tomperez98 wants to merge 3 commits into
Open
Tomperez98 wants to merge 3 commits into
Tomperez98 wants to merge 3 commits into
Conversation
Only the promiseId<->lineage boundary uses ':'; lineage segments keep '.' (foo.1 -> foo:1, foo.1.1 -> foo:1.1).
Remove the promise/task ID prefix feature entirely: the builder prefix
option, the internal idPrefix/prefixId state and helper, and the
resonate:prefix tag emission. Root ids are used raw; detached ids root
on the lineage origin.
Part of the new promise id format (':' lineage separator + no prefix).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New promise id format
Promise ids now use the form
<promiseId>:<lineage>::(foo→foo:1); deeper lineage segments stay dot-separated (foo:1.1).prefixoption, noprefixId, and the SDK no longer emits theresonate:prefixtag. Root ids are used raw; detached ids root on the lineage origin.Only
resonate:origin/resonate:branch/resonate:parentare emitted now, consistent across all Resonate SDKs.Verification
./gradlew build— SUCCESSFUL (spotless + compile + tests)