Designated follower system, party menu uses follower sprites#98
Open
benitogf wants to merge 1 commit into
Open
Designated follower system, party menu uses follower sprites#98benitogf wants to merge 1 commit into
benitogf wants to merge 1 commit into
Conversation
- Designated follower system (party menu Follow option, SaveBlock1 field) - Follower interaction fix: name/cry uses designated follower instead of first live mon - Follower icon vertical centering and shift-up for party menu - Gengar sprite replacements and shiny palette updates - Golbat/Zubat/Scyther shiny palette fixes - Various UI/QoL tweaks (naming screen, debug, trade, trainer card)
Owner
|
Hi! I've been busy, so I'm commenting a bit late. I have to thoroughly review your changes; however, at first glance, I noticed:
It'll take a while for me to review everything else, as I don't have free time to do much. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This implements a designated follower, so we can select a different mon than the first one in the party
It also implements changes to the trainer card and the party menu to use the follower sprites instead of the icons, this allows the party menu to reflect the shiny pokemons
Discord contact info
under_.tow