Skip to content

Designated follower system, party menu uses follower sprites#98

Open
benitogf wants to merge 1 commit into
resetes12:masterfrom
benitogf:experiment/hns-port
Open

Designated follower system, party menu uses follower sprites#98
benitogf wants to merge 1 commit into
resetes12:masterfrom
benitogf:experiment/hns-port

Conversation

@benitogf
Copy link
Copy Markdown

  • Designated follower system (party menu Follow option, SaveBlock1 field)
  • Follower interaction fix: name/cry uses designated follower instead of first live mon
  • Follower icon vertical centering and shift-up for party menu
  • Gengar sprite replacements and shiny palette updates
  • Golbat/Zubat/Scyther shiny palette fixes
  • Various UI/QoL tweaks (naming screen, debug, trade, trainer card)

Description

This implements a designated follower, so we can select a different mon than the first one in the party
It also implements changes to the trainer card and the party menu to use the follower sprites instead of the icons, this allows the party menu to reflect the shiny pokemons

Discord contact info

under_.tow

- Designated follower system (party menu Follow option, SaveBlock1 field)
- Follower interaction fix: name/cry uses designated follower instead of first live mon
- Follower icon vertical centering and shift-up for party menu
- Gengar sprite replacements and shiny palette updates
- Golbat/Zubat/Scyther shiny palette fixes
- Various UI/QoL tweaks (naming screen, debug, trade, trainer card)
@resetes12
Copy link
Copy Markdown
Owner

resetes12 commented May 6, 2026

Hi! I've been busy, so I'm commenting a bit late. I have to thoroughly review your changes; however, at first glance, I noticed:

  • Emerald sprites shouldn't be touched, so I won't use the FRLG sprite for Gengar or any other, even if they are technically better (plus I already created a FRLG 64x64 Sprite resource, fyi).
  • I don't want updated icons for the player party, even though they are probably better, as I want the Emerald ones.
  • There are reasons why the player party isn't mirrored in the Trainer Card (while in HnS they are), so that's also a no.
  • I wouldn't mind having a designated follower system though. That's a great change.

It'll take a while for me to review everything else, as I don't have free time to do much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants