Repository navigation
fix(editor): add uppercase mark to inspector text panel - #3850
Merged
felipefreitag merged 3 commits intoNov 13, 2026
Merged
Conversation
MARK_NAMES missed 'uppercase', so inspector marks state never tracked the mark while the bubble menu toggle worked. Closes resend#3849
Contributor
|
@svargas-dev is attempting to deploy a commit to the resend Team on Vercel. A member of the Team first needs to authorize it. |
🦋 Changeset detectedLatest commit: d83bcff The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The toggle was always visible. Only its pressed state was wrong.
felipefreitag
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InspectorTextderives mark active state from the hardcodedMARK_NAMESlist."uppercase"was missing, so the inspector Text panel never tracked theUppercasemark even thoughFORMAT_ITEMSrenders its toggle and the bubble menu (BubbleMenuUppercase) works. The toggle rendered but stayed visually inactive (aria-pressedalwaysfalse).Adds
"uppercase"toMARK_NAMES, matching the schema and the bubble menu.Changes
packages/editor/src/ui/inspector/text.tsx: add"uppercase"toMARK_NAMESpackages/editor/src/ui/inspector/text.spec.tsx: new test asserting the uppercase toggle renders and reflects active mark state.changeset/inspector-uppercase-mark.md:patchchangeset for@react-email/editorValidation
pnpm biome checkon changed files, cleanpnpm --filter @react-email/editor typecheck, cleanpnpm testinpackages/editor: 55 unit files / 523 tests and 4 browser files / 19 tests, all passpnpm --filter @react-email/editor build: regenerateddist/ui/index.mjs/index.cjscontain"uppercase"inMARK_NAMES(dist is gitignored, not committed)Closes #3849
Summary by cubic
Fixes the inspector text panel so the Uppercase toggle correctly reflects the active mark state.
MARK_NAMESwas missing"uppercase", so the toggle rendered but always appeared inactive even when the mark was applied.Written for commit d83bcff. Summary will update on new commits.