Skip to content

chore(deps): remove normalize-path dependency - #3782

Merged
dielduarte merged 4 commits into
resend:canaryfrom
LuggaPugga:chore/remove-normalize-path
Oct 27, 2026
Merged

dielduarte merged 4 commits into
resend:canaryfrom
LuggaPugga:chore/remove-normalize-path

Conversation

@LuggaPugga

@LuggaPugga LuggaPugga commented Oct 9, 2026 •

Copy link
Copy Markdown
Contributor

Remove normalize-path dependency

The output directory is now passed to glob through the cwd option instead of being part of the pattern, so no path normalization is needed:

const allBuiltTemplates = glob.sync('**/*.cjs', {
  cwd: pathToWhereEmailMarkupShouldBeDumped,
  absolute: true,
});

This also removes the unused @types/normalize-path from packages/ui.

Behavior

Nothing changes for ordinary output directories. One side effect is a fix: an --outDir containing glob characters was previously treated as part of the pattern.

--outDir Before After
out[1], out{a,b} No templates found, nothing rendered Templates render
out* Also picked up .cjs files from sibling directories Only that directory is searched

Summary by cubic

Removes the normalize-path dependency by passing --outDir to glob's cwd option instead of concatenating it into the pattern.

Fixes two edge cases: --outDir values containing glob characters (like out[1] or out{a,b}) previously matched no templates, and values like out* previously pulled in .cjs files from sibling directories. Both now correctly search only the intended output directory. Also removes the unused @types/normalize-path from packages/ui.

Written for commit b8d7b03. Summary will update on new commits.

View guided diff

@changeset-bot

changeset-bot Bot commented Oct 9, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: b8d7b03

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
react-email Patch
@react-email/editor Patch
@react-email/ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

@LuggaPugga is attempting to deploy a commit to the resend Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added the linear-synced PR has been synced to Linear label Oct 9, 2026
@dielduarte
dielduarte self-requested a review October 27, 2026 15:56
@pkg-pr-new

pkg-pr-new Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/react-email@3782
npm i https://pkg.pr.new/@react-email/ui@3782

commit: b8d7b03

@dielduarte
dielduarte force-pushed the chore/remove-normalize-path branch from 6e6bd23 to 3d78cd1 Compare October 27, 2026 17:24
@vercel

vercel Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
react-email Ready Ready Preview Oct 27, 2026 5:40pm UTC
react-email-demo Ready Ready Preview Oct 27, 2026 5:40pm UTC

Request Review

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@dielduarte dielduarte left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!!

@dielduarte
dielduarte merged commit 499caa6 into resend:canary Oct 27, 2026
12 checks passed

This branch was successfully deployed

2 active deployments
Preview – react-email-demo — b8d7b03d Deployed Oct 27, 2026 by vercel[bot]
Preview – react-email — b8d7b03d Deployed Oct 27, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

linear-synced PR has been synced to Linear

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants