Remove 1s buffer from cordon range - #226
Merged
Merged
Conversation
since it works so well that having the buffer actually results in early cancelation.
erbridge
approved these changes
Oct 15, 2025
erbridge
left a comment
erbridge
left a comment
Contributor
There was a problem hiding this comment.
Removing arbitrary buffers because we don't need them is always nice 👍
|
Hello how are you? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd added the 1s buffer because I thought it would be necessary to match deadlines that are exactly the server time (rounded to the second), but this turned out to be too big of a buffer, as real production workloads were getting canceled ~1s early.