-
Notifications
You must be signed in to change notification settings - Fork 54
feat(rn_cli_wallet): refactor Maestro Pay E2E tests with inline payment creation #455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ignaciosantise
wants to merge
7
commits into
main
Choose a base branch
from
feat/maestro-pay-tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
0c0d977
feat(rn_cli_wallet): refactor Maestro Pay E2E tests with inline payme…
ignaciosantise b36e74e
fix: convert hex cast output to decimal in balance-check workflow
ignaciosantise 6ff9d99
fix: drop cast to-dec, trim whitespace from cast call output
ignaciosantise bfb3115
fix: check USDC on Optimism instead of OP token
ignaciosantise 0462ba5
fix: add missing MULTI_NOKYC secrets to CI maestro commands
ignaciosantise 375f6a4
fix: free disk space and reduce emulator partition to fix CI android OOM
ignaciosantise bf12b19
fix: sign iOS simulator build and add Android keystore for CI deeplinks
ignaciosantise File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| appId: ${APP_ID} | ||
| --- | ||
| # Shared flow: Tap Pay, verify loading, wait for success, tap "Got it!" | ||
|
|
||
| # On review screen, tap Pay button | ||
| - extendedWaitUntil: | ||
| visible: | ||
| id: "pay-button-pay" | ||
| timeout: 10000 | ||
| - tapOn: | ||
| id: "pay-button-pay" | ||
|
|
||
| # Verify confirming screen (optional — may flash by quickly) | ||
| - runFlow: | ||
| when: | ||
| visible: | ||
| id: "pay-loading-message" | ||
| commands: | ||
| - assertVisible: | ||
| id: "pay-loading-message" | ||
|
|
||
| # Wait for success screen (generous timeout for on-chain confirmation) | ||
| - extendedWaitUntil: | ||
| visible: | ||
| id: "pay-result-success-icon" | ||
| timeout: 30000 | ||
|
|
||
| # Tap "Got it!" button | ||
| - tapOn: | ||
| id: "pay-button-result-action" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| appId: ${APP_ID} | ||
| --- | ||
| # Shared flow: Launch wallet, open scanner, paste payment URL, wait for merchant info | ||
| # Requires: ${output.gateway_url} to be set by a prior runScript step | ||
|
|
||
| # Launch wallet app | ||
| - launchApp: | ||
| appId: ${APP_ID} | ||
| permissions: | ||
| all: allow | ||
|
|
||
| # Tap scan button to open scanner options modal | ||
| - tapOn: | ||
| id: "button-scan" | ||
|
|
||
| # Type the payment URL into the test input field | ||
| - tapOn: | ||
| id: "input-paste-url" | ||
|
|
||
| # Dismiss iOS keyboard language prompt if it appears | ||
| - runFlow: | ||
| when: | ||
| visible: "Continue" | ||
| commands: | ||
| - tapOn: "Continue" | ||
|
|
||
| - inputText: ${output.gateway_url} | ||
| - pressKey: Enter | ||
| - tapOn: | ||
| id: "button-submit-url" | ||
|
|
||
| # Wait for payment options to load with merchant info | ||
| - extendedWaitUntil: | ||
| visible: | ||
| id: "pay-merchant-info" | ||
| timeout: 15000 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| appId: ${APP_ID} | ||
| --- | ||
| # Shared flow: Open payment URL via deep link and wait for merchant info | ||
| # Requires: ${output.gateway_url} to be set by a prior runScript step | ||
|
|
||
| # Open the payment URL as a deep link | ||
| - openLink: ${output.gateway_url} | ||
|
|
||
| # Wait for payment options to load with merchant info | ||
| - extendedWaitUntil: | ||
| visible: | ||
| id: "pay-merchant-info" | ||
| timeout: 15000 |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.