ci: attach demo files to release directly instead of zipping#34
Merged
Conversation
The vhs container (debian:stable-slim) ships no zip binary, so the
Bundle-for-release step failed with exit 127 on tag builds. Drop the
zip step and attach hero.{gif,mp4,webm} straight to the release via
softprops/action-gh-release -- zero new dependency, and hero.gif now
previews inline on the release page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
demosworkflow fails on tag builds:The
Bundle for releasestep runscd demos/out && zip -r ../../demos.zip .inside the VHS container (ghcr.io/charmbracelet/vhs:v0.11.0). That image's final stage isdebian:stable-slim, which ships nozipbinary — hence exit 127. The step only runs onv*tags, so it stayed hidden until the first tagged release.Fix
Drop the zip step entirely and attach the rendered media straight to the GitHub Release via
softprops/action-gh-release'sfiles:list.demos/out/after render is exactly three files —hero.gif(tracked),hero.mp4+hero.webm(gitignored, regenerated). Bundling three files into an archive nobody can preview added no value. Direct attach:zipdependency)apt-get install+ debian-mirror round-trip on every taghero.gifnow previews inline on the release page; mp4/webm download as-isAlternative considered
apt-get update && apt-get install -y zip(root user, so no sudo) would keep a singledemos.zip. Rejected: a network install on every release to bundle 3 previewable files is strictly worse than attaching them directly.Test plan
v*tag (or re-run the failed release) and confirm theAttach to releasestep uploads all three assets.