Stop the browser from mixing UI files from two deploys - #44
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a deploy, a browser could load the new
index.htmlwith a cachedapp.jsfrom the previous deploy. The old script looked up#api-url, which the new page no longer has, and the UI showed "Request failed: Cannot set properties of null (setting 'hidden')".The gateway now serves every UI page, script, and stylesheet with
Cache-Control: no-cache, so the browser revalidates each file on load. Basic Auth still guards each route.A test in
tests/gateway.test.tschecks the header on all six UI routes.Made with Cursor