fix(scripting): sort selected devices by name when added - #1167
Merged
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Devices selected for a script run were kept in click order (or, for select-all, whatever sort the device list happened to be using). That order carried straight through to the created job, so the Targets chips and the Devices list on the job detail page came out unsorted.
Sorting once at selection time means the order is right from the first click and nothing has to re-sort later — the run form chips, the submitted
deviceIds, and the resulting job all inherit it.Changes
sortSelectedIds(selected, devices)added tohelpers/selectionRange.ts, alongside the existingmergeSelectedIds/removeSelectedIds. UseslocaleComparewithnumeric: truesodozer-2sorts ahead ofdozer-10.ui.selected:useSelect(click and shift-range) andDeviceListHeaderCheckbox(select-all).DeviceScriptingMenusets a single id, so it needs no sort. Nothing in the job fetch or socket-update path was touched — existing jobs render exactly as before.Notes
ui.selectedis shared with the other bulk device actions (tagging, transfer, delete), so those selections are name-ordered now too.Testing
tsc --noEmitpasses.jobDeviceson its own.