Skip to content

fix(auth): open mobile OAuth in external browser to keep keyboard working #1115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JamieRuderman wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(auth): open mobile OAuth in external browser to keep keyboard working #1115

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions frontend/src/cognito/auth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,7 +243,12 @@ export class AuthService {
`scope=${this.scope.join('+')}`,
]
const authUrl = `https://${this.config.cognitoAuthDomain}/oauth2/authorize?${params.join('&')}`
await windowOpen(authUrl, 'auth')
// Open the hosted UI in the external system browser rather than the in-app
// browser. On iOS, presenting and dismissing the in-app browser (SFSafariViewController)
// over the WKWebView leaves the web view unable to raise the soft keyboard, so
// returning to the sign-in form (e.g. after canceling) breaks email/password entry.
// The auth flow returns via the authCallback deep link, so an external browser works.
await windowOpen(authUrl, 'auth', true)
// await this.loginWithCognito() @TODO implement with oauth2
}

Expand Down Expand Up @@ -433,7 +438,9 @@ export class AuthService {
`scope=${this.scope.join('+')}`,
]
const logoutUrl = `https://${this.config.cognitoAuthDomain}/logout?${params.join('&')}`
await windowOpen(logoutUrl, 'auth')
// Use the external browser (see mobileAuth) so the WKWebView keyboard keeps
// working on the sign-in form the user returns to after signing out.
await windowOpen(logoutUrl, 'auth', true)
}
await this.cognitoAuth.signOut()
} catch {}
Expand Down
Loading