Open
Conversation
…OAA-GFDL#1775) * Refactor MPP_GATHER_PELIST_3D_ to implement 3D gathers using the existing MPP_GATHER_1D(V)_ routines, leveraging collective communication instead of manual point-to-point sends/recvs. * Remove trailing whitespace
Co-authored-by: vithikashah001 <vithikashah001@github.com>
* Refactor of MPI-IO support in fms2_io MPI-IO support in fms2_io has been refactored. `open_collective_netcdf_file` has been removed and its functionality has been merged into `netcdf_file_open`. Parallel reads and writes are now enabled using the same interface and code pathways. * Specify argument names in `netcdf_file_open` call Use explicit names for the optional arguments of `netcdf_file_open`, when it's called within `open_domain_file`. * netcdf_read_data_*: Call nf90_var_par_access later In the netcdf_read_data_* subroutines, move the calls to nf90_var_par_access so that they run later. * Fix domain reads when MPI-IO is enabled Update the domain read subroutines so that they set the indices correctly when use_netcdf_mpi is enabled. * Remove fallback test for collective reads Remove the test which attempts to open a 64-bit NetCDF file in collective read mode. Attempting to do so will now fail rather than fall back to a standard read without MPI-IO. * Restore working version of netcdf_read_data.inc Undo changes to netcdf_read_data.inc which were committed unintentionally. * Update call to open_file in diag_manager * Restore collective read unit test Restore the unit test which attempts to open a 64-bit NetCDF file for MPI-IO collective reads. Change from `test_expect_success` to `test_expect_failure`. * Explain MPI-IO features in README Add an explanation of fms2_io's MPI-IO support to the readme.md file. --------- Co-authored-by: Jesse Lentz <jesse@twosheds.org> Co-authored-by: Jesse Lentz <jesse.lentz@noaa.gov>
* Add a unit test to reproduce the issue with cell_measures when there are multiple files with it * Fix so that the area cell measures attribute is written correctly * Fix line length issue
… variable (NOAA-GFDL#1813) * Add a new test to test multiple zbounds limit * Refactor the code that it can support multiple variable with zbounds in the same file * Add new test to cmake lists * address Ryan's review comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Include a summary of the change and which issue is fixed. Please also include
relevant motivation and context. List any dependencies that are required for
this change.
Fixes # (issue)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Please also note
any relevant details for your test configuration (e.g. compiler, OS). Include
enough information so someone can reproduce your tests.
Checklist:
make distcheckpasses