Repository navigation
fix(ci): rebuild service images when their workspace packages change #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,12 +5,28 @@ on: | |
| branches: [ main ] | ||
| paths: | ||
| - 'apps/backend/api-key/**' | ||
| - 'packages/auth/**' | ||
| - 'packages/bus/**' | ||
| - 'packages/cache/**' | ||
| - 'packages/code-samples/**' | ||
| - 'packages/db/**' | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Two close pushes to |
||
| - 'packages/dns/**' | ||
| - 'packages/tsconfig/**' | ||
| - 'packages/webhook-events/**' | ||
| - 'docker-compose.setup.yml' | ||
| - '.github/workflows/be-api-key.yml' | ||
| pull_request: | ||
| branches: [ main ] | ||
| paths: | ||
| - 'apps/backend/api-key/**' | ||
| - 'packages/auth/**' | ||
| - 'packages/bus/**' | ||
| - 'packages/cache/**' | ||
| - 'packages/code-samples/**' | ||
| - 'packages/db/**' | ||
| - 'packages/dns/**' | ||
| - 'packages/tsconfig/**' | ||
| - 'packages/webhook-events/**' | ||
| - 'docker-compose.setup.yml' | ||
| - '.github/workflows/be-api-key.yml' | ||
| workflow_dispatch: | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A fork PR that changes only
packages/dbnow starts this workflow. Fork PRs do not receive the Docker Hub secrets, butdocker/login-actionruns before the build and needs them. The check fails before it can build the image. Skip login on PR runs that do not push an image.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!