Add HTTP authentication support#239
Merged
lubomir merged 15 commits intoMar 25, 2026
Merged
Conversation
Assisted-by: Claude Opus
Assisted-by: Claude Opus
Assisted-by: Claude Opus
Assisted-by: Claude Opus
Assisted-by: Claude Opus
Assisted-by: Claude Opus
Assisted-by: Claude Opus
Assisted-by: Claude Opus
Assisted-by: Claude Opus
lubomir
reviewed
Mar 25, 2026
Contributor
lubomir
left a comment
There was a problem hiding this comment.
Should the retries be updated not not retry on auth errors? It's not a big deal, but if the credentials are wrong, retry won't help and the user just has to wait longer.
Assisted-by: Claude Opus
lubomir
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #237
Add HTTP authentication to the
localizecommand so it can download files from servers that require credentials (e.g. Pulp).Authentication methods
--http-tokenPRODUCTMD_HTTP_TOKEN--http-username+--http-passwordPRODUCTMD_HTTP_PASSWORD--netrc-file(optional)PRODUCTMD_NETRC_FILEImplementation decisions
netrc,base64,urllib.parse, andurllib.requestfrom the standard library. A library likerequestswould arguably be more robust, but keeping it stdlib-only avoids adding a runtime dependency for what is ultimately straightforward HTTP header handling.Authorizationheader is stripped on cross-origin redirects (matches curl behavior). Port normalization handlesNonevs explicit default port (443/80).--http-tokenand--http-username/--http-passwordcannot be combined; username and password must be provided together. Enforced at both CLI and library level.