Skip to content

Update arena configs from maDisplayTools#108

Closed
github-actions[bot] wants to merge 1 commit into
mainfrom
auto/sync-arena-configs
Closed

Update arena configs from maDisplayTools#108
github-actions[bot] wants to merge 1 commit into
mainfrom
auto/sync-arena-configs

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Automated Arena Config Sync

This PR was automatically generated by the sync-arena-configs workflow.

Source: maDisplayTools/configs/arenas/

Changes

The js/arena-configs.js file has been regenerated from the latest YAML configs in maDisplayTools.

Review Checklist

  • Verify the config changes look correct
  • Test the arena editor and 3D viewer with the updated configs

@github-actions
github-actions Bot force-pushed the auto/sync-arena-configs branch from 77d60f4 to 0fbdbab Compare June 14, 2026 00:28
mbreiser pushed a commit that referenced this pull request Jun 16, 2026
The sync-arena-configs workflow fetched only configs/arenas/, never
configs/arena_registry/index.yaml, so in CI the generator found no registry
source and silently emitted ARENA_REGISTRY = {} — wiping the arena name<->ID
map. Surfaced as the destructive auto-PRs #95 and #108.

- workflow: mirror the maDisplayTools layout (temp_configs/{arenas,arena_registry}),
  fetch index.yaml alongside the arenas, pass the arenas dir to the generator.
- generator: refuse to emit an empty ARENA_REGISTRY (exit 1) so a missing source
  fails the job loudly instead of opening a destructive PR.

Verified against real upstream data: correct layout regenerates the full
G4/G4.1/G6 registry; a missing registry now aborts before writing.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@mbreiser

Copy link
Copy Markdown
Contributor

Closing — this is the destructive output of the arena-config sync bug, not a change to merge.

Root cause: the sync-arena-configs workflow fetched only configs/arenas/ and never configs/arena_registry/index.yaml, so in CI the generator found no registry source and silently emitted an empty ARENA_REGISTRY — wiping the G4 / G4.1 / G6 arena name↔ID map. (main's file was fine because it was last generated locally, where the registry resolves from the sibling maDisplayTools checkout.)

Fixed on main in 98c57a7 (LAB-111):

The next sync run will regenerate the file with the registry intact.

@mbreiser mbreiser closed this Jun 16, 2026
@mbreiser
mbreiser deleted the auto/sync-arena-configs branch June 16, 2026 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant