fix(tests): remove duplicate test_python_function_adapter_non_dict_structured_raises#2
Closed
regokan wants to merge 1 commit into
Closed
fix(tests): remove duplicate test_python_function_adapter_non_dict_structured_raises#2regokan wants to merge 1 commit into
regokan wants to merge 1 commit into
Conversation
…ructured_raises The Tier 2 parallel example dispatch resulted in two PRs (structured_extraction and text_to_sql) each independently adding the same test function name to the shared test_python_function_adapter.py. The first PR (structured_extraction) added it at line 131 with a list-returning async agent; subsequent PRs added a second definition at line 200 with a string-returning sync agent. Both cover the same case (structured field is not a dict -> AdapterError); the first definition is canonical. Ruff F811 caught the redefinition on main, breaking CI for the second and third PRs that landed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Owner
Author
|
Superseded by ea37bb0 on main, which renames the duplicate test (test_python_function_adapter_str_structured_raises) instead of deleting it — the two tests exercise different non-dict shapes (list vs string), so renaming preserves the second data point while this PR would drop it. Ruff is green on main; no further action needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests/unit/test_adapters/test_python_function_adapter.pyTest plan
uv run --no-sync ruff check .→ All checks passed