Repository navigation
docs: honest privacy wording, prerequisites, Next.js badge, troubleshooting page - #1839
Merged
Merged
Conversation
…ooting page - README tagline says the video never leaves the device (anonymous analytics are sent, so "nothing is uploaded" overstated it); same in docs/USAGE.md. - Next.js 16 badge; prerequisites: Bun 1.x and Node.js 20.9+ (README, CONTRIBUTING). - GSSoC section explains /assign and that maintainers add labels. - docs/TROUBLESHOOTING.md (the old README's Troubleshooting/FAQ, updated): bun install --frozen-lockfile and report the error, never delete bun.lock; linked from the README. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Deploy Preview for reframe-os ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
Bot
added
level:intermediate
Contributor
👋 Thanks for your PR, @magic-peach!Welcome to Reframe — a browser-based video editor built for everyone 🎬
What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
Contributor
|
Contributor
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 2 additions, from your review of the README. Most points were already fixed by the rewrite in #1833 (merged). This PR does the rest. Status of each point against the README now on
main:docs/USAGE.md). The Privacy section has your wording, with the Settings opt-out.docs/assets/demo-placeholder.svg).magic-peach→reframe-ossreframe-oss/reframe.LICENSE(renamed in #1833).netlify.toml, not "CORS")docs/DEPLOYMENT.md; the old note is gone./assign, GSSoC logo/assign, links how it works, and says maintainers add labels. The logo is still the placeholder from #1833 until you add the official file.bun.lock; usebun install --frozen-lockfileand report the error; move Troubleshooting/FAQ to docs/docs/TROUBLESHOOTING.md, linked from the README quick start. It says never to deletebun.lock, to run--frozen-lockfileand report the full error, and covers the frozen-lockfile message, env vars, the single-threaded engine inbun run dev, stalled exports, and the FAQ.&max=500CODE_OF_CONDUCT.mdline 39[INSERT CONTACT METHOD]SECURITY.mdhas the same placeholder ([maintainer email]).Also: a code comment in
DatadogInit.tsxcalled Reframe "100% private"; it now gives the real reason replay is off.No code behaviour changes.