Repository navigation
feat(privacy): anonymous analytics switch, Do Not Track, footer credits - #1834
Merged
Merged
Conversation
- Settings (privacy page, linked from the footer): an "Anonymous analytics" switch saved in localStorage. When off, DatadogInit doesn't load the SDK; if it's turned off on a page where RUM already started, beforeSend drops every further event and custom events stop. - Do Not Track and Global Privacy Control keep it off, and the switch says why. - RUM: defaultPrivacyLevel "mask" (replay stays off), and trackAnonymousUser: false, so there is no persistent usr.anonymous_id; production events were carrying one. - Privacy page: the telemetry section now says exactly which coarse export details are sent, instead of claiming no export settings are. - Footer: "This site is powered by Netlify", "Security by Snyk", GitHub and license links; the Code of Conduct link points at reframe-oss/reframe. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
✅ Deploy Preview for reframe-os ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Contributor
👋 Thanks for your PR, @magic-peach!Welcome to Reframe — a browser-based video editor built for everyone 🎬 What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
…e redesigned footer Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
magic-peach
marked this pull request as ready for review
November 3, 2026 16:43
Contributor
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 2, part 2: privacy controls and footer credits. The docs half is #1833.
What changes
Anonymous analytics switch (Settings)
/privacy#settings), linked from the footer as Settings. It holds an "Anonymous analytics" switch (role="switch"), saved inlocalStorage(reframe_analytics).DatadogInitnever loads or initialises the Datadog SDK and makes no request to Datadog (tested).beforeSenddrops every further event and custom events stop.Privacy settings in the RUM SDK, confirmed in code and tests
sessionReplaySampleRate: 0(replay stays off).defaultPrivacyLevel: "mask", newly added.enablePrivacyForActionName: true.trackAnonymousUser: false, newly added. Real production events were carrying a persistentusr.anonymous_id, which lets sessions be linked across visits.beforeSendalso removesusras a backstop.sanitizeRumEventtests. No properties beyond the documented buckets (format, resolution, size and length ranges, overlay flags): covered byexportTelemetry.test.ts's allowed-keys test.Needs a setting in Datadog (not possible from code). Datadog adds IP-derived location (country, city, latitude and longitude) to every event on its servers, and production events have it. The RUM application API doesn't expose that setting. To turn it off: Datadog → Digital Experience → your RUM application ("reframe") → its settings → user data collection, then turn off geolocation and client IP collection.
Privacy page wording. It used to say telemetry "does not and cannot include… export settings", which wasn't true. It now lists exactly what export events carry.
Footer. The bottom bar now has "This site is powered by Netlify" (→ netlify.com, the wording Netlify's open source plan asks for; the badge stays), "Security by Snyk" (→ snyk.io), GitHub and MIT License links. The Code of Conduct link now points to
reframe-oss/reframeinstead ofmagic-peach/reframe. The License link targetsLICENSE, which #1833 renames fromMIT LICENSE, so merge #1833 first or that link 404s until it is.Checks run locally
bun run test: 29 files, 313 tests pass. New:analyticsConsent.test.ts: the default, the stored choice, DNT, GPC, blocked storage, events stopping when turned off, andusrstripped;DatadogInit.consent.test.tsx: no initialisation or Datadog requests when off, under DNT or under GPC, plus the init options;AnalyticsSettings.test.tsx: the switch saves its state, and is disabled under DNT.off; the footer links are as above; no horizontal scroll at 390 px.