Repository navigation
docs(contributing): document Next.js 16 --webpack requirement for FFmpeg.wasm - #1821
Open
chiragjangiir wants to merge 1 commit into
Open
chiragjangiir wants to merge 1 commit into
chiragjangiir wants to merge 1 commit into
Conversation
👷 Deploy request for reframe-os pending review.Visit the deploys page to approve it
|
Contributor
👋 Thanks for your PR, @chiragjangiir!Welcome to Reframe — a browser-based video editor built for everyone 🎬 What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
Contributor
✅ PR Format Check Passed — @chiragjangiirBasic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
github-actions
Bot
added
level:beginner
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #1780.
Following the Next.js 16 upgrade,
package.json'sdevandbuildscripts explicitly pass--webpackbecause Next.js 16 defaults to Turbopack. Turbopack ignores or errors onnext.config.ts's custom Webpack configuration (config.resolve.fallback = { fs: false }), which is strictly required for@ffmpeg/ffmpegWebAssembly resolution.Previously, this requirement was only noted in a brief code comment inside
next.config.ts. Contributors looking through developer documentation could inadvertently remove or "simplify" the scripts without knowing it breaks WebAssembly loading.Changes
9. Webpack Requirement for Next.js 16 (--webpack)toCONTRIBUTING.mdunder Development Tips detailing why--webpackis present and why removing it breaks FFmpeg.wasm loading.Verification
bun run lint(passed with 0 errors).next.config.tsandpackage.json.