Repository navigation
docs: update Keyboard Shortcuts table with all implemented shortcuts - #1820
Open
chiragjangiir wants to merge 1 commit into
Open
chiragjangiir wants to merge 1 commit into
chiragjangiir wants to merge 1 commit into
Conversation
👷 Deploy request for reframe-os pending review.Visit the deploys page to approve it
|
Contributor
👋 Thanks for your PR, @chiragjangiir!Welcome to Reframe — a browser-based video editor built for everyone 🎬 What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
Contributor
✅ PR Format Check Passed — @chiragjangiirBasic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
github-actions
Bot
added
level:beginner
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #1779.
The Keyboard Shortcuts table in
README.mdwas previously incomplete and contained an inaccurate key combination:Ctrl+Enter / Cmd+Enterfor video export, whereas the implementation insrc/hooks/useKeyboardShortcuts.tslistens forCtrl/Cmd + Shift + E.src/hooks/useKeyboardShortcuts.tsandsrc/components/VideoEditor.tsx'sKeyboardShortcutsPanel:R(Reset all settings)1–9(Switch preset by index)I(Set trim in-point)O(Set trim out-point)?(Toggle keyboard shortcuts panel)Changes
README.mdto accurately document all 9 keyboard shortcuts currently active in the application (Ctrl+Shift+E / Cmd+Shift+E,Space,M,R,Escape,1–9,I,O,?).Verification
src/hooks/useKeyboardShortcuts.ts,src/components/VideoPreview.tsx, andsrc/components/VideoEditor.tsx.bun run lint(passed with 0 errors).