Repository navigation
fix(layout): make video preview sticky while scrolling editing tools (#1511) - #1816
Open
Tarulatapriya wants to merge 1 commit into
Open
Tarulatapriya wants to merge 1 commit into
Tarulatapriya wants to merge 1 commit into
Conversation
👷 Deploy request for reframe-os pending review.Visit the deploys page to approve it
|
Contributor
👋 Thanks for your PR, @Tarulatapriya!Welcome to Reframe — a browser-based video editor built for everyone 🎬 What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
github-actions
Bot
added
level:beginner
Contributor
✅ PR Format Check Passed — @TarulatapriyaBasic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Fixes #1511.
Currently, editing controls (Trim, Rotation, Audio, Adjustments, Text Overlays, Format, Image Overlays) are stacked vertically below the video player. Scrolling down to adjust any of these options causes the video player to scroll out of view, forcing users to constantly scroll back and forth to see their changes.
This PR makes the video preview sticky on desktop viewports (
lg:sticky lg:top-16 lg:z-30 lg:shadow-md):Verification
npx tsc --noEmit— 0 errors.eslint— 0 errors, 0 warnings.npx next build --webpack— 0 errors, static export succeeded.