Repository navigation
fix(theme): remove unused film CSS token declarations - #1812
Open
Mohamedajab wants to merge 1 commit into
Open
Mohamedajab wants to merge 1 commit into
Mohamedajab wants to merge 1 commit into
Conversation
The film Tailwind palette already maps to accent tokens, so these disconnected raw custom properties have no consumers and misleading values. Fixes reframe-oss#1772
👷 Deploy request for reframe-os pending review.Visit the deploys page to approve it
|
Contributor
👋 Thanks for your PR, @Mohamedajab!Welcome to Reframe — a browser-based video editor built for everyone 🎬
What happens next
Quick checklist
Useful links
Happy coding! 🎉 |
github-actions
Bot
added
level:beginner
Contributor
✅ PR Format Check Passed — @MohamedajabBasic format checks passed. A maintainer will review your code changes. This does not mean the PR is approved — it just means the format is correct. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove four unused
--film-*custom properties. Tailwind's film palette already uses the accent tokens, and no source files reference the removed properties.Related Issue
Closes #1772.
Type of Contribution
Participant Info
Validation
Source inspection confirms the removed properties have no consumers. No rendered UI change is intended. Browser testing, lint and typechecking have not been run for this PR.
Screen Recording
Not applicable to removal of unused declarations; no visible behaviour changes.
Checklist