fix(antd,mui,mantine): notification type rendering & breadcrumb styling & accessibility - #7514
Open
bhumin18 wants to merge 5 commits into
Open
fix(antd,mui,mantine): notification type rendering & breadcrumb styling & accessibility#7514bhumin18 wants to merge 5 commits into
bhumin18 wants to merge 5 commits into
Conversation
Fixes refinedev#7477 - antd: Use notification.success()/error() shortcut methods instead of notification.open({type}) which doesn't render type-specific icons/colors - mantine: Properly distinguish success (green/check) vs error (red/x) instead of treating all non-success types as error - Updated antd notification provider tests to verify correct methods are called
Fixes refinedev#7462 The LinkRouter helper was spreading MUI LinkProps (sx, underline, color, variant) onto a plain <span>, which doesn't understand them. Replaced with <MuiLink component='span'> so the styling props are properly processed by MUI's styling system. This was a regression from commit 5d63ada (v5 migration, refinedev#6945) which removed the old ActiveLink-based rendering but never re-wired the props to an actual MUI component.
Icon-only buttons in undoable notifications were missing aria-label attributes, making them inaccessible to screen readers (WCAG 2.1 SC 4.1.2). - antd: Added aria-label='undo' to Button in UndoableNotification - mui: Added aria-label='undo' to IconButton in notificationProvider - mantine: Added aria-label='undo' to ActionIcon in notificationProvider
…nd sider Added aria-label attributes to IconButton components that only contain icons (no text), improving accessibility for screen readers: - create/edit/show pages: aria-label='go back' on back navigation button - sider: aria-label='collapse sidebar' on collapse button These icon-only buttons were previously inaccessible to screen reader users (WCAG 2.1 SC 4.1.2 - Name, Role, Value).
🦋 Changeset detectedLatest commit: fc361f6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes 2 open issues and improves accessibility across multiple UI packages.
Bug Fixes
Fixes #7477 — Notification type not respected in @refinedev/antd and @refinedev/mantine
notification.success()/error()shortcut methods instead ofnotification.open({type})which doesn't render type-specific icons/colorssuccess→ green/✓ anderror→ red/✕ instead of treating all non-success types as redFixes #7462 — MUI Breadcrumb links lose all styling
<span>with<MuiLink component="span">in the Breadcrumb'sLinkRoutersosx,underline,color, andvariantprops are properly processedAccessibility Improvements
aria-labelto icon-only buttons across antd, mui, and mantine packages (WCAG 2.1 SC 4.1.2)Tests