fix(react-table): only reset the current page when filters or sorters actually change - #7512
Open
MarioRial22 wants to merge 1 commit into
Open
fix(react-table): only reset the current page when filters or sorters actually change#7512MarioRial22 wants to merge 1 commit into
MarioRial22 wants to merge 1 commit into
Conversation
… actually change The columnFilters/sorting sync effects reset currentPage to 1 on every effect re-run with a non-empty filter/sort — the isEqual guard covered setFilters/setSorters but not the page reset. The filters effect is keyed on [columnFilters, columns], so any columns identity change re-fired it; with syncWithLocation, useNavigation()'s callbacks are location-sensitive, so columns memoized over them are recreated by the pagination click's own URL push: page 2 was fetched and immediately snapped back to page 1. Move both resets inside their isEqual guards. A real filter/sorter change still resets the page (covered by a new spec), identity churn no longer does (covered by a new spec that fails on the previous implementation), and deep links keep working via the existing isFirstRender guard.
🦋 Changeset detectedLatest commit: 4aa2e10 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
What is the current behavior?
useTable'scolumnFilters/sortingsync effects resetcurrentPageto 1 on every effect re-run while a filter or sort is active — theisEqualguard coverssetFilters/setSortersbut not the page reset: